diff --git a/Dockerfile b/Dockerfile index 297baa8..de69a81 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,8 +1,8 @@ -FROM node:23-alpine3.21 +FROM node:24-alpine RUN apk upgrade --update-cache --available ARG VERSION -LABEL version=${VERSION}} description="BadgeDex" +LABEL version=${VERSION} description="BadgeDex" ENV APP_VERSION=${VERSION} # Create a group and user && Create directory for files @@ -18,7 +18,7 @@ USER badgedex COPY --chown=badgedex:badgedex . . #Install dependencies -RUN npm install +RUN npm ci --only=production # Expose API port EXPOSE 3000 diff --git a/src/lib/version.js b/src/lib/version.js index 3d519af..f53a678 100644 --- a/src/lib/version.js +++ b/src/lib/version.js @@ -2,8 +2,8 @@ const fs = require('fs'); const version = () => { - if (process.env.VERSION) { - return process.env.VERSION; + if (process.env.APP_VERSION) { + return process.env.APP_VERSION; } // Fallback to reading from a VERSION file const versionPath = require('path').resolve(__dirname, '../../VERSION');